Update unknown values in move data #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 29, 2023
Frostbyte0x70
approved these changes
Jul 29, 2023
| # 0x14 1 uint8 Unk#17 Boolean, whether the move can be used while taunted. | ||
| self.ignores_taunted = bool(read_u8(data, 0x14)) | ||
| # 0x15 1 uint8 Unk#18 Unknown. Possible bitfield. | ||
| self.unk15 = read_u8(data, 0x15) | ||
| # 0x15 1 uint8 Unk#18 Determines the string that is displayed for the range of the move in-game |
There was a problem hiding this comment.
You could clarify that the value is offset by a certain amount here, but I guess it's not too important.
Test Results 12 files ±0 12 suites ±0 1h 6m 17s ⏱️ +35s For more details on these failures, see this check. Results for commit 0e07a0c. ± Comparison against base commit 0bc157f. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also: